Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 (CoreMotor): Move & rename CoreMotorBase to interface/drivers/Motor.h #757

Merged
merged 8 commits into from
May 6, 2022
Merged

🚚 (CoreMotor): Move & rename CoreMotorBase to interface/drivers/Motor.h #757

merged 8 commits into from
May 6, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented May 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #757 (29a6a5d) into develop (1009491) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 29a6a5d differs from pull request most recent head dec7c53. Consider uploading reports for the commit dec7c53 to get more accurate results

@@             Coverage Diff             @@
##           develop     #757      +/-   ##
===========================================
- Coverage    93.94%   93.94%   -0.01%     
===========================================
  Files          111      110       -1     
  Lines         2413     2412       -1     
===========================================
- Hits          2267     2266       -1     
  Misses         146      146
Impacted Files Coverage Δ
libs/RobotKit/include/RobotController.h 90.84% <ø> (ø)
drivers/CoreMotor/include/CoreMotor.h 100.00% <100.00%> (ø)
libs/BehaviorKit/include/BehaviorKit.h 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145308 (55%) 116836 (44%) 30048 (5%)
os 362700 (23%) 1201972 (76%) 75320 (14%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ✅ 362700 (17%) ø 75320 (14%) ø
bootloader ✔️ ✅ ✅ 145308 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 258248 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 92008 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194112 (9%) ø 30384 (5%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 194596 (9%) ø 53976 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 233916 (11%) ø 33864 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152840 (7%) ø 52528 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88992 (4%) ø 19744 (3%) ø
spike_lk_command_kit ✔️ ❌ ✅ 199476 (9%) ø 54880 (10%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136740 (6%) ø 20368 (3%) ø
spike_lk_coreled ✔️ ✅ ✅ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 127820 (6%) ø 20216 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331692 (15%) ø 33536 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 168364 (8%) ø 52640 (10%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115148 (5%) ø 20504 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 85016 (4%) ø 18512 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86584 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 111724 (5%) ø 20504 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 85784 (4%) ø 17488 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90976 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82752 (3%) ø 17648 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145268 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145308 (55%) 116836 (44%) 30048 (5%)
os 343720 (21%) 1220952 (78%) 69088 (13%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 343720 (16%) ø 69088 (13%) ø
bootloader ✔️ ✅ ✅ 145308 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250704 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174584 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 92008 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177976 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 185228 (8%) ø 48032 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 225248 (10%) ø 27808 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 187900 (8%) ø 48680 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124204 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 103604 (4%) ø 14048 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326984 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 158108 (7%) ø 46568 (8%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 102708 (4%) ø 14560 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 101804 (4%) ø 14560 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78580 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122788 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas ladislas force-pushed the ladislas/feature/add-mock-motor branch 2 times, most recently from 2bce13e to 29a6a5d Compare May 6, 2022 13:02
@ladislas ladislas requested a review from HPezz May 6, 2022 13:03
@ladislas ladislas self-assigned this May 6, 2022
@ladislas ladislas added the 01 - type: task Something to do label May 6, 2022
@ladislas ladislas added this to the v1.0.0 milestone May 6, 2022
HPezz
HPezz approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM c'est très agréable cette épuration

@ladislas ladislas force-pushed the ladislas/feature/add-mock-motor branch from 29a6a5d to dec7c53 Compare May 6, 2022 14:07
@ladislas ladislas merged commit 001e97d into develop May 6, 2022
@ladislas ladislas deleted the ladislas/feature/add-mock-motor branch May 6, 2022 14:14
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HPezz HPezz HPezz approved these changes

Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @HPezz